Skip to content
Snippets Groups Projects
  1. Feb 14, 2021
  2. Feb 13, 2021
  3. Feb 12, 2021
  4. Feb 11, 2021
  5. Feb 10, 2021
    • Philip Withnall's avatar
      tests: Add tests for key name handling in the keyfile backend · 68ce7a28
      Philip Withnall authored
      
      This tests the two recent commits.
      
      Signed-off-by: default avatarPhilip Withnall <pwithnall@endlessos.org>
      68ce7a28
    • Philip Withnall's avatar
      gkeyfilesettingsbackend: Disallow empty key or group names · a5924760
      Philip Withnall authored
      
      These should never have been allowed; they will result in precondition
      failures from the `GKeyFile` later on in the code.
      
      A test will be added for this shortly.
      
      Signed-off-by: default avatarPhilip Withnall <pwithnall@endlessos.org>
      a5924760
    • Philip Withnall's avatar
      gkeyfilesettingsbackend: Fix basename handling when group is unset · 9d27c57f
      Philip Withnall authored
      
      Fix an effective regression in commit
      7781a9cb, which happens when
      `convert_path()` is called with a `key` which contains no slashes. In
      that case, the `key` is entirely the `basename`.
      
      Prior to commit 7781a9cb, the code worked through a fluke of `i == -1`
      cancelling out with the various additions in the `g_memdup()` call, and
      effectively resulting in `g_strdup (key)`.
      
      Spotted by Guido Berhoerster.
      
      Signed-off-by: default avatarPhilip Withnall <pwithnall@endlessos.org>
      9d27c57f
    • Philip Withnall's avatar
      Merge branch 'fix_more_warnings' into 'master' · efe49e46
      Philip Withnall authored
      Fix more warnings
      
      See merge request GNOME/glib!1938
      efe49e46
    • Emmanuel Fleury's avatar
      Fix missing initializer warning in gio/glib-compile-resources.c · bdcd7eca
      Emmanuel Fleury authored
      gio/glib-compile-resources.c: In function ‘parse_resource_file’:
      gio/glib-compile-resources.c:553:3: error: missing initializer for field ‘passthrough’ of ‘GMarkupParser’ {aka ‘struct _GMarkupParser’}
        553 |   GMarkupParser parser = { start_element, end_element, text };
            |   ^~~~~~~~~~~~~
      bdcd7eca
    • Emmanuel Fleury's avatar
      Fix several signedness warnings in gio/gio-tool-tree.c · 7c7aec9b
      Emmanuel Fleury authored
      gio/gio-tool-tree.c: In function ‘do_tree’:
      gio/gio-tool-tree.c:124:22: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’
        124 |        for (n = 0; n < level; n++)
            |                      ^
      gio/gio-tool-tree.c:197:21: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’
        197 |       for (n = 0; n < level; n++)
            |                     ^
      7c7aec9b
    • Emmanuel Fleury's avatar
      Fix missing initializer warning in gio/gio-tool-monitor.c · a54ebd68
      Emmanuel Fleury authored
      gio/gio-tool-monitor.c:48:3: error: missing initializer for field ‘description’ of ‘GOptionEntry’ {aka ‘const struct _GOptionEntry’}
         48 |   { G_OPTION_REMAINING, 0, 0, G_OPTION_ARG_FILENAME_ARRAY, &watch_default },
            |   ^
      a54ebd68
    • Emmanuel Fleury's avatar
      Fix signedness warning in gio/gio-tool.c:attribute_flags_to_string() · 85f24921
      Emmanuel Fleury authored
      gio/gio-tool.c: In function ‘attribute_flags_to_string’:
      gio/gio-tool.c:171:17: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’
        171 |   for (i = 0; i < G_N_ELEMENTS (flag_descr); i++)
            |                 ^
      85f24921
    • Emmanuel Fleury's avatar
      Fix several missing initializer warnings in gio/glib-compile-schemas.c · 6b3e39fa
      Emmanuel Fleury authored
      gio/glib-compile-schemas.c: In function ‘parse_gschema_files’:
      gio/glib-compile-schemas.c:1773:3: error: missing initializer for field ‘passthrough’ of ‘GMarkupParser’ {aka ‘struct _GMarkupParser’}
       1773 |   GMarkupParser parser = { start_element, end_element, text };
            |   ^~~~~~~~~~~~~
      gio/glib-compile-schemas.c: In function ‘main’:
      gio/glib-compile-schemas.c:2176:5: error: missing initializer for field ‘arg_description’ of ‘GOptionEntry’ {aka ‘struct _GOptionEntry’}
       2176 |     { "allow-any-name", 0, 0, G_OPTION_ARG_NONE, &allow_any_name, N_("Do not enforce key name restrictions") },
            |     ^
      6b3e39fa
    • Emmanuel Fleury's avatar
      Fix several signedness warnings in gio/glib-compile-schemas.c · 93f3831e
      Emmanuel Fleury authored
      gio/glib-compile-schemas.c: In function ‘key_state_set_range’:
      gio/glib-compile-schemas.c:376:17: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘long unsigned int’
        376 |   for (i = 0; i < G_N_ELEMENTS (table); i++)
            |                 ^
      gio/glib-compile-schemas.c: In function ‘key_state_serialise’:
      gio/glib-compile-schemas.c:714:29: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘long unsigned int’
        714 |               for (i = 0; i < size / sizeof (guint32); i++)
            |                             ^
      93f3831e
    • Emmanuel Fleury's avatar
      Fix several signedness warnings in gio/gsettings-mapping.c · 8b1959da
      Emmanuel Fleury authored
      gio/gsettings-mapping.c: In function ‘g_settings_set_mapping_int’:
      gio/gsettings-mapping.c:65:23: error: comparison of integer expressions of different signedness: ‘gint64’ {aka ‘long int’} and ‘long unsigned int’
         65 |       if (0 <= l && l <= G_MAXUINT64)
            |                       ^~
      gio/gsettings-mapping.c: In function ‘g_settings_set_mapping_float’:
      gio/gsettings-mapping.c:120:23: error: comparison of integer expressions of different signedness: ‘gint64’ {aka ‘long int’} and ‘long unsigned int’
        120 |       if (0 <= l && l <= G_MAXUINT64)
            |                       ^~
      gio/gsettings-mapping.c: In function ‘g_settings_get_mapping_int’:
      gio/gsettings-mapping.c:224:27: error: comparison of integer expressions of different signedness: ‘gint64’ {aka ‘long int’} and ‘long unsigned int’
        224 |       return (0 <= l && l <= G_MAXUINT64);
            |                           ^~
      gio/gsettings-mapping.c: In function ‘g_settings_get_mapping_float’:
      gio/gsettings-mapping.c:269:27: error: comparison of integer expressions of different signedness: ‘gint64’ {aka ‘long int’} and ‘long unsigned int’
        269 |       return (0 <= l && l <= G_MAXUINT64);
            |                           ^~
      8b1959da
    • Emmanuel Fleury's avatar
      Fix wrong position for static qualifier warning in fuzzing/fuzz_dbus_message.c · 1f8d8b39
      Emmanuel Fleury authored
      fuzzing/fuzz_dbus_message.c:3:1: error: ‘static’ is not at beginning of declaration
          3 | const static GDBusCapabilityFlags flags = G_DBUS_CAPABILITY_FLAGS_UNIX_FD_PASSING;
            | ^~~~~
      1f8d8b39
Loading