GitLab

Until we allow to bind all keys let's allow for these as well since
this block includes e.g. PrintScreen for screenshots.

Passing an invalid keybinding currently doesn't end well:

 ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0xaaaaadbff580 bp 0xffffc1f94d00 sp 0xffffc1f94d00 T0)
 The signal is caused by a READ memory access.
 Hint: address points to the zero page.
    #0 0xaaaaadbff580 in phosh_private_keyboard_event_accelerator_is_registered ../src/phosh.c:131
    #1 0xaaaaadbff7d8 in phosh_private_accelerator_already_subscribed ../src/phosh.c:149
    #2 0xaaaaadbffa68 in phosh_private_keyboard_event_grab_accelerator_request ../src/phosh.c:184
    #3 0xffffafb47044  (/lib/aarch64-linux-gnu/libffi.so.7+0x6044)
    #4 0xffffafb4676c  (/lib/aarch64-linux-gnu/libffi.so.7+0x576c)
    #5 0xffffb0031a1c in wl_closure_invoke ../src/connection.c:1018
    #6 0xffffb002cd7c in wl_client_connection_data ../src/wayland-server.c:432
    #7 0xffffb002fa64 in wl_event_loop_dispatch ../src/event-loop.c:1027
    #8 0xaaaaadbdce38 in wayland_event_source_dispa...

Always set and check both keybinding results. This tests that
we don't invoke the wrong callback accidentally.

Currently one needs to look up what's tested in an array but each most
of the keys are only used a single time. So drop that array and use a
define for the single key that is used multiple times so it's clear we
just add an accelerator.

The current accelerator tests try to encode two boolean values
into two variables making it a bit hard to read. Use a single
enum instead.

Don't try to go on without a cursor (which can only happen when calloc
fails). wlroots also only returns NULL in case of memory problems.

This allows to remove the NULL checks elsewhere

This commit adds the `build-dep` one-liner to install the dependencies
by leveraging the debian control file. The instructions are from
the same section in phosh's README. Also fixes a typo in the building
section, which seems to be from phosh.

See https://github.com/swaywm/wlroots/pull/1919

Move the cursor under the finger until touch points receive their own
cursors.

Otherwise the old cursor stays there until the pointer gets moved.

This also removes the destroy signal listener of the pending surface.

There's no need to redraw unactivated clients since they're
hidden anyway, so that just wastes resources. It also looks
bad in phosh activity chooser.

The actual window geometry should stay in the same position
regardless of surface geometry being changed.

We're interested in restoring the actual window into the same
position, regardless of whether the shadows around it happened
to change their size meanwhile.

This makes it consistent with PHOC_EDGE_SNAP_THRESHOLD and actually makes
more sense.

This follows the convention used by other projects like phosh.

We've been using proper wlroots packaging for a long time now.

This allows them to run as soon as the dependency is fulfilled, before
the previous stage has been completed.

This ensures that the view is still on the list while it may get
damaged by children handlers - otherwise phoc_desktop_view_is_visible
won't be able to work correctly.

Fixes #191

If the view is unmapped, we can tell that it's not visible right
away. Later assertion assumes that there's at least one view on
the desktop->views list, which is a valid assumption to make only
if the view we got is actually mapped.

Should fix #191

Every wlr_output is going to have an associated PhocOutput, but
wlr_output_layout_output_at is not guaranteed to always return
a non-NULL value. Therefore it doesn't make much sense to check
for `output` being NULL right after unchecked dereference
of `wlr_output`.

It's useful to have when testing custom wlroots builds on the phone.

We still want to be able to reveal shell when there's no surface
at the edge of the screen - which can happen when the fullscreen
surface's size doesn't cover the whole output.

Some apps open windows with preferred size that are larger than
the phone screen, but that can be resized down manually to fit.
There's no reason not to try to make them fit on the screen
automatically, so do just that when centering views.

It's simpler and does the same thing :)

It's not really a useful feature to have in a mobile compositor and just
makes positioning code more complicated for no good reason. It wasn't
even complete, as evidenced by TODOs being removed with it. Support for
iterating over and drawing rotated surfaces is retained as it may still
be useful, but we sure don't need it at the view level.

Setting force_shell_reveal changes the contents of the output, so
it needs to be damaged. It is already done in all the other places
where it's changed.