Skip to content
Snippets Groups Projects
  1. Sep 06, 2020
  2. Aug 31, 2020
  3. Aug 19, 2020
  4. Jul 28, 2020
  5. Jun 19, 2020
  6. Jun 08, 2020
    • Guilherme G. Piccoli's avatar
      scripts/functions: Prevents printf error carry over if wrong console is set · c3cbf355
      Guilherme G. Piccoli authored
      
      Currently the _log_msg() functions is "void" typed - with no return -,
      which in terms of shell means it returns whatever its last command
      returns. This function is the basic building block for all error/warning
      messages in initramfs-tools.
      
      It was noticed [0] that in case of bad console is provided to kernel on
      command-line, printf (and apparently all write()-related functions) returns
      error, and so this error is carried over in _log_msg(). Happens that
      checkfs() function has a loop that runs forever in this scenario (*if* fsck
      is not present in initramfs, and obviously if "quiet" is not provided in the
      command-line). The situation is easily reproducible and we can find various
      reports dating back some years. The reports usually are of the form
      "machine can't boot if wrong console is provided" or slightly different
      forms of that, almost always relating serial consoles with boot issues.
      
      This patch proposes a pretty simple fix: return zero on _log_msg().
      We should definitely not brake the boot due to error log functions;
      one could argue we could fix checkfs() and that's true, until eventually
      we find another subtle corner case of "misuse" of the _log_msg() return
      value (after some debugging), and fix that too, and so on...
      W could also argue that printf shouldn't return error in this case,
      and although a valid discussion, it's not worth to have users waiting
      on a dilemma while boot is quite easy to brake, just by passing a wrong
      kernel parameter (or having the underlying serial console device changed
      to output to a different port than the previously set on kernel cmdline).
      
      [0] bugs.launchpad.net/cloud-images/+bug/1573095/comments/46
      Signed-off-by: default avatarGuilherme G. Piccoli <gpiccoli@canonical.com>
      c3cbf355
  7. May 24, 2020
    • Vagrant Cascadian's avatar
      hook-functions: Add modules needed for Pinebook LCD display. · 482897b9
      Vagrant Cascadian authored
      The Pinebook LCD disply does not show output until after the initramfs
      is loaded, which is too late to enter an encryption passphrase or
      debug issues with mounting the rootfs.
      
      Fix this by adding modules to "fb": analogix-anx6345, pwm-sun4i,
      sun4i-drm and sun8i-mixer.
      482897b9
  8. Apr 28, 2020
  9. Mar 29, 2020
  10. Jan 30, 2020
  11. Jan 18, 2020
Loading